Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The translated R code for the OCSB test included a
if max_lag == 0
, which has special meaning in R, since it's 1-indexed, not 0-indexed. We need to check for<= 0
in order to fix #191.Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Added a new unit test in
pmdarima/arima/tests/test_arima.py
Checklist: