Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MRG+1] Fix issue 191 #193

Merged
merged 6 commits into from
Oct 24, 2019
Merged

[MRG+1] Fix issue 191 #193

merged 6 commits into from
Oct 24, 2019

Conversation

tgsmith61591
Copy link
Member

@tgsmith61591 tgsmith61591 commented Oct 23, 2019

Description

The translated R code for the OCSB test included a if max_lag == 0, which has special meaning in R, since it's 1-indexed, not 0-indexed. We need to check for <= 0 in order to fix #191.

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation change

How Has This Been Tested?

Added a new unit test in pmdarima/arima/tests/test_arima.py

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

Copy link
Member

@aaronreidsmith aaronreidsmith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@aaronreidsmith aaronreidsmith changed the title [MRG] Fix issue 191 [MRG+1] Fix issue 191 Oct 23, 2019
@tgsmith61591 tgsmith61591 merged commit 45756a5 into master Oct 24, 2019
@tgsmith61591 tgsmith61591 deleted the fix-issue-191 branch October 24, 2019 11:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Negative dimensions are not allowed
2 participants