Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[MRG+1] Fix aarch builds #565

Merged
merged 3 commits into from
Oct 23, 2023
Merged

[MRG+1] Fix aarch builds #565

merged 3 commits into from
Oct 23, 2023

Conversation

aaronreidsmith
Copy link
Member

@aaronreidsmith aaronreidsmith commented Oct 23, 2023 •
edited
Loading

Description

Fixes our aarch builds so they deploy with the correct version

Type of change

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

GITHUB_REF is now set for Linux builds (example)

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

@aaronreidsmith aaronreidsmith changed the title [WIP] Fix aarch builds [MRG] Fix aarch builds Oct 23, 2023
@aaronreidsmith aaronreidsmith marked this pull request as ready for review October 23, 2023 15:05
tgsmith61591
tgsmith61591 reviewed Oct 23, 2023
View reviewed changes
.github/workflows/build_and_deploy.yml
@@ -72,7 +72,7 @@ jobs:
pip install -r build_tools/build_requirements.txt &&
pip install -r requirements.txt
CIBW_BUILD: "${{ env.PYTHON_EXECUTABLE }}-*"
CIBW_ENVIRONMENT: CC=gcc
CIBW_ENVIRONMENT: CC=gcc GITHUB_REF=${{ env.GITHUB_REF }}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So goofy

@tgsmith61591 tgsmith61591 changed the title [MRG] Fix aarch builds [MRG+1] Fix aarch builds Oct 23, 2023
@aaronreidsmith aaronreidsmith merged commit e9905d3 into master Oct 23, 2023
29 checks passed
@aaronreidsmith aaronreidsmith deleted the fix-aarch-builds branch October 23, 2023 15:28
@aaronreidsmith aaronreidsmith mentioned this pull request Oct 23, 2023
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tgsmith61591 tgsmith61591 tgsmith61591 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@aaronreidsmith @tgsmith61591