Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Quote in
headingWithPipes.md
Previous unit test
headingWithPipes
fails because of the quote.The HTML generated by Jekyll in
_site/
:(It's more complicated in original version. I manually edit the HTML file to this.)
What
tests.py
thinks:If I add
encoding='utf-8'
when opening files intests.py
, it becomesOK
. (pythonopen()
with GBK by default on Windows 10 Chinese ver. — It depends on locale.) Therefore, this might be a platform-dependent issue, and do not implytoc.html
or Jekyll works wrongly.So I remove the quote.
Python 2.7 in Contributing Guide
Change the python version from 2.7 to 3 in contributing guide. I think it was a mistake.
Details on the Python Version
The contributing guide says
In
tests.py
, there's even f-string (a python 3.6 feature)!jekyll-toc/tests.py
Line 18 in 8d5aafd
I run
tests.py
in python 3.7 - 3.10, and all works. (python 2.7 and 3.6 are both end-of-life)