Fix

allenjzhang · Jun 7, 2024 · e2e30ab · e2e30ab
1 parent d3ddb2d
commit e2e30ab
Show file tree

Hide file tree

Showing 4 changed files with 8 additions and 11 deletions.
diff --git a/packages/samples/common-types/openapi/v3/types.json b/packages/samples/common-types/openapi/v3/types.json
@@ -709,7 +709,7 @@
       "required": true,
       "type": "string",
       "minLength": 1,
-      "x-ms-parameter-location": "method",
+      "x-ms-parameter-location": "client",
       "x-ms-client-name": "apiVersion"
     },
     "LocationParameter": {
@@ -747,7 +747,7 @@
       "description": "The ID of the target subscription.  The value must be an UUID.",
       "required": true,
       "type": "string",
-      "x-ms-parameter-location": "method"
+      "x-ms-parameter-location": "client"
     }
   }
 }
diff --git a/packages/samples/common-types/openapi/v4/types.json b/packages/samples/common-types/openapi/v4/types.json
@@ -720,7 +720,7 @@
       "required": true,
       "type": "string",
       "minLength": 1,
-      "x-ms-parameter-location": "method",
+      "x-ms-parameter-location": "client",
       "x-ms-client-name": "apiVersion"
     },
     "LocationParameter": {
@@ -779,7 +779,7 @@
       "required": true,
       "type": "string",
       "format": "uuid",
-      "x-ms-parameter-location": "method"
+      "x-ms-parameter-location": "client"
     },
     "TenantIdParameter": {
       "name": "tenantId",

diff --git a/packages/samples/common-types/openapi/v5/types.json b/packages/samples/common-types/openapi/v5/types.json
@@ -720,7 +720,7 @@
       "required": true,
       "type": "string",
       "minLength": 1,
-      "x-ms-parameter-location": "method",
+      "x-ms-parameter-location": "client",
       "x-ms-client-name": "apiVersion"
     },
     "LocationParameter": {
@@ -779,7 +779,7 @@
       "required": true,
       "type": "string",
       "format": "uuid",
-      "x-ms-parameter-location": "method"
+      "x-ms-parameter-location": "client"
     },
     "TenantIdParameter": {
       "name": "tenantId",

diff --git a/packages/samples/common-types/src/types.tsp b/packages/samples/common-types/src/types.tsp
@@ -5,11 +5,8 @@ using OpenAPI;
 
 namespace Azure.ResourceManager.CommonTypes;
 
-@@extension(OperationIdParameter, "x-ms-parameter-location", "method");
-
-@@extension(ResourceGroupNameParameter, "x-ms-parameter-location", "method");
-
-@@extension(LocationParameter, "x-ms-parameter-location", "method");
+@@extension(ApiVersionParameter.apiVersion, "x-ms-parameter-location", "client");
+@@extension(SubscriptionIdParameter.subscriptionId, "x-ms-parameter-location", "client");
 
 op registerParams(
   ...ApiVersionParameter,