Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Look into removing fake search term when forcing the search template #162

Open
mboynes opened this issue Sep 16, 2023 · 0 comments
Open
Labels
enhancement New feature or request

Comments

@mboynes
Copy link
Contributor

mboynes commented Sep 16, 2023

Description

See this comment which prompts this issue.

Some history: 10 years ago (exactly) when I built the integration, I believe that if the s query arg was an empty string, the query would not be considered a "search query" and WordPress wouldn't render the search template. It's certainly possible that that was an oversight on my part, I'm not sure. Regardless, it looks like that's not the case now. Perhaps instead of using a phony search term, we can get away with setting s to an empty string.

Use Case

When a user forces the search template, SP should set s to an empty string instead of a phony search term so that the search term will render without inserting a hacky meaningless string.

@mboynes mboynes added the enhancement New feature or request label Sep 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant