Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adjust empty-string search integrations #161

Merged
merged 4 commits into from
Sep 16, 2023
Merged

Adjust empty-string search integrations #161

merged 4 commits into from
Sep 16, 2023

Conversation

mboynes
Copy link
Contributor

@mboynes mboynes commented Sep 15, 2023 •
edited
Loading

  • Fixes a regression with forced empty searches (unsets the temp search string)
  • Adds a filter to be able to override the integration

@mboynes mboynes changed the title Remove temp search string for empty searches Adjust empty-string search integrations Sep 15, 2023
dlh01
dlh01 approved these changes Sep 16, 2023
View reviewed changes
Copy link
Member

@dlh01 dlh01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🌳

lib/class-sp-integration.php Outdated Show resolved Hide resolved
lib/class-sp-integration.php Show resolved Hide resolved
@mboynes mboynes mentioned this pull request Sep 16, 2023
Open
@mboynes mboynes merged commit ba251c2 into release/0.5 Sep 16, 2023
4 checks passed
@mboynes mboynes deleted the hotfix/fix-forced-search-tpl-string branch September 16, 2023 18:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dlh01 dlh01 dlh01 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mboynes @dlh01