Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Trim trailing slashes from ES host value #117

Merged
merged 3 commits into from
Jun 11, 2020
Merged

Trim trailing slashes from ES host value #117

merged 3 commits into from
Jun 11, 2020

Conversation

benpbolton
Copy link
Member

Should resolve #92
[body] => {"error":"Incorrect HTTP method for uri [...] "status":405}

@benpbolton
Trim trailing slashes from ES host value
f099fc7 
Should resolve #92

[body] => {"error":"Incorrect HTTP method for uri [...] "status":405}
@benpbolton
Copy link
Member Author

Failing phpcs checks due to WordPress.Security.NonceVerification.Recommended warnings unrelated to this patch; might warrant a deeper dive alongside replacement use of gmdate()

@mslinnea mslinnea changed the base branch from master to release/0.5 June 11, 2020 20:03
@mslinnea mslinnea merged commit 0741c87 into release/0.5 Jun 11, 2020
@srtfisher srtfisher deleted the hotfix/TOOL/remove_es_host_trailing_slashes branch December 1, 2020 16:37
@srtfisher srtfisher mentioned this pull request Dec 1, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mboynes mboynes mboynes approved these changes

@kevinfodness kevinfodness Awaiting requested review from kevinfodness

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Requests may fail if host setting ends in trailing slash
3 participants
@benpbolton @mboynes @mslinnea