Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

check vars first #35

Merged
merged 2 commits into from
Sep 20, 2016
Merged

check vars first #35

merged 2 commits into from
Sep 20, 2016

Conversation

timatron
Copy link
Contributor

No description provided.

Copy link
Contributor

@mboynes mboynes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some additional cleanup can be done, then 👍

$this->flush();
}

if ( $assoc_args['put-mapping'] ) {
if ( ! empty( $assoc_args['put-mapping'] ) && $assoc_args['put-mapping'] ) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These can just check ! empty(), you can erase the && ...

@timatron
Copy link
Contributor Author

Want me to do the other vars?

Sent from my iPhone

On Sep 19, 2016, at 19:03, Matthew Boynes notifications@github.com wrote:

@mboynes approved this pull request.

Some additional cleanup can be done, then 👍

In bin/wp-cli.php:

        $this->flush();
  }
  • if ( $assoc_args['put-mapping'] ) {
    
  • if ( ! empty( $assoc_args['put-mapping'] ) && $assoc_args['put-mapping'] ) {
    
    These can just check ! empty(), you can erase the && ...


You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or mute the thread.

@timatron timatron merged commit 77b91b2 into master Sep 20, 2016
@renatonascalves renatonascalves deleted the bug-index-args branch February 22, 2019 00:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants