Make improvements #383
Merged
Make improvements #383
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use .test/ for building the test target so that we can use test specific compile options
Now that the apteryx library is linked to by both daemon and client we use apteryx_debug and the rpc code from the library.
sparlane
reviewed
Sep 26, 2023
| @install -d $(DESTDIR)/$(PREFIX)/lib/pkgconfig | ||
| @install -D apteryx.pc $(DESTDIR)/$(PREFIX)/lib/pkgconfig/ | ||
|
|
||
| clean: | ||
| @echo "Cleaning..." | ||
| @rm -f libapteryx.so* apteryx.so apteryx apteryxd *.o | ||
| @rm -fr libapteryx.so* apteryx.so apteryx apteryxd *.o .test |
There was a problem hiding this comment.
Should this include/be $BUILDDIR ?
sparlane
reviewed
Sep 26, 2023
test.c
Outdated
There was a problem hiding this comment.
Can you drop this patch and the patch it effectively reverts?
Now the last user of the unix socket file will unlink the file
carlgsmith
force-pushed
the
make_improvements
branch
from
cedb6b4
to
5b9fb38
Compare
Path to BUILDDIR already added via EXTRA_LDFLAGS
sparlane
approved these changes
Sep 27, 2023
sparlane
approved these changes
Sep 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.