Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump the test group with 1 update #4693

Merged
merged 1 commit into from
Feb 2, 2024

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Jan 29, 2024

Bumps the test group with 1 update: puppeteer.

Updates puppeteer from 21.9.0 to 21.10.0

Release notes

Sourced from puppeteer's releases.

puppeteer-core: v21.10.0

21.10.0 (2024-01-29)

Features

  • add experimental browser.debugInfo (#11748) (f88e1da)
  • download chrome-headless-shell by default and use it for the old headless mode (#11754) (ce894a2)

Bug Fixes

puppeteer: v21.10.0

21.10.0 (2024-01-29)

Features

  • download chrome-headless-shell by default and use it for the old headless mode (#11754) (ce894a2)

Dependencies

  • The following workspace dependencies were updated
    • dependencies
      • puppeteer-core bumped from 21.9.0 to 21.10.0
Commits

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore <dependency name> major version will close this group update PR and stop Dependabot creating any more for the specific dependency's major version (unless you unignore this specific dependency's major version or upgrade to it yourself)
  • @dependabot ignore <dependency name> minor version will close this group update PR and stop Dependabot creating any more for the specific dependency's minor version (unless you unignore this specific dependency's minor version or upgrade to it yourself)
  • @dependabot ignore <dependency name> will close this group update PR and stop Dependabot creating any more for the specific dependency (unless you unignore this specific dependency or upgrade to it yourself)
  • @dependabot unignore <dependency name> will remove all of the ignore conditions of the specified dependency
  • @dependabot unignore <dependency name> <ignore condition> will remove the ignore condition of the specified dependency and ignore conditions

@dependabot dependabot bot added dependencies Pull requests that update a dependency file javascript labels Jan 29, 2024
@dependabot dependabot bot requested a review from a team January 29, 2024 14:13
Copy link

github-actions bot commented Jan 29, 2024

📋 Stats

File sizes

File Size
dist/govuk-frontend-development.min.css 112.45 KiB
dist/govuk-frontend-development.min.js 38.58 KiB
packages/govuk-frontend/dist/govuk/all.bundle.js 78.74 KiB
packages/govuk-frontend/dist/govuk/all.bundle.mjs 73.99 KiB
packages/govuk-frontend/dist/govuk/all.mjs 3.86 KiB
packages/govuk-frontend/dist/govuk/govuk-frontend-component.mjs 359 B
packages/govuk-frontend/dist/govuk/govuk-frontend.min.css 112.44 KiB
packages/govuk-frontend/dist/govuk/govuk-frontend.min.js 38.57 KiB
packages/govuk-frontend/dist/govuk/i18n.mjs 5.38 KiB

Modules

File Size
all.mjs 70.32 KiB
components/accordion/accordion.mjs 21.67 KiB
components/button/button.mjs 4.7 KiB
components/character-count/character-count.mjs 21.24 KiB
components/checkboxes/checkboxes.mjs 5.83 KiB
components/error-summary/error-summary.mjs 6.57 KiB
components/exit-this-page/exit-this-page.mjs 16.08 KiB
components/header/header.mjs 4.46 KiB
components/notification-banner/notification-banner.mjs 4.93 KiB
components/radios/radios.mjs 4.83 KiB
components/skip-link/skip-link.mjs 4.39 KiB
components/tabs/tabs.mjs 10.16 KiB

View stats and visualisations on the review app


Action run for 6651002

Bumps the test group with 1 update: [puppeteer](https://github.com/puppeteer/puppeteer).

Updates `puppeteer` from 21.9.0 to 21.10.0
- [Release notes](https://github.com/puppeteer/puppeteer/releases)
- [Changelog](https://github.com/puppeteer/puppeteer/blob/main/release-please-config.json)
- [Commits](puppeteer/puppeteer@puppeteer-v21.9.0...puppeteer-v21.10.0)

---
updated-dependencies:
- dependency-name: puppeteer
  dependency-type: direct:production
  update-type: version-update:semver-minor
  dependency-group: test
...

Signed-off-by: dependabot[bot] <support@github.com>
romaricpascal
romaricpascal previously approved these changes Jan 29, 2024
Copy link
Member

@romaricpascal romaricpascal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ran the usual npm install to counteract Dependabot listing puppeteer in dependencies.

@romaricpascal romaricpascal dismissed their stale review January 29, 2024 15:02

Missed the download by default of chrome shell

Copy link
Member

@romaricpascal romaricpascal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added the necessary env variable to skip the download of the chrome-headless-shell that Puppeteer now downloads automatically, but we don't use (we use new headless mode and take care of the binary download ourselves anyway).

Using HEADLESS=false npm run test still works as intended in development.

This means this PR will need a second review, though. cc @alphagov/design-system-developers

@colinrotherham
Copy link
Contributor

@romaricpascal From puppeteer/puppeteer#11754 it looks like PUPPETEER_SKIP_DOWNLOAD is enough?

  1. Use PUPPETEER_SKIP_DOWNLOAD to skip all downloads
  2. Use PUPPETEER_SKIP_CHROME_DOWNLOAD to skip Chrome only
  3. Use PUPPETEER_SKIP_CHROME_HEADLESS_SHELL_DOWNLOAD to skip Chrome headless shell only

Appears to be the case by looking through their options:

https://github.com/puppeteer/puppeteer/blob/31a23399a96a6c7e1e5603b5b3431c68f12fd33d/packages/puppeteer-core/src/common/Configuration.ts#L92-L109

@colinrotherham
Copy link
Contributor

colinrotherham commented Jan 29, 2024

@romaricpascal I've re-triggered one of the failed checks in this PR

I'm seeing the same failures sporadically on other PRs, caused by make-synchronized which came in a recent @prettier/sync release via #4687 if you can help revert it please:

Copy link
Contributor

@colinrotherham colinrotherham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@romaricpascal Morning! 👋

Do you mind checking if we can drop the new commit based on #4693 (comment)?

Then we can merge this

@romaricpascal
Copy link
Member

From puppeteer/puppeteer#11754 it looks like PUPPETEER_SKIP_DOWNLOAD is enough?

Missed that bit at the end, good spot! I'll remove that extra commit 😊

@romaricpascal romaricpascal force-pushed the dependabot/npm_and_yarn/test-80503005ef branch from b03173d to 6651002 Compare February 2, 2024 10:07
@govuk-design-system-ci govuk-design-system-ci temporarily deployed to govuk-frontend-pr-4693 February 2, 2024 10:07 Inactive
@colinrotherham colinrotherham merged commit 18cc100 into main Feb 2, 2024
89 checks passed
@colinrotherham colinrotherham deleted the dependabot/npm_and_yarn/test-80503005ef branch February 2, 2024 12:33
owenatgov pushed a commit that referenced this pull request Apr 4, 2024
…0503005ef

Bump the test group with 1 update
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file javascript
Projects
Development

Successfully merging this pull request may close these issues.

3 participants