-
Notifications
You must be signed in to change notification settings - Fork 320
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump the test group with 1 update #4693
Conversation
📋 StatsFile sizes
Modules
View stats and visualisations on the review app Action run for 6651002 |
Bumps the test group with 1 update: [puppeteer](https://github.com/puppeteer/puppeteer). Updates `puppeteer` from 21.9.0 to 21.10.0 - [Release notes](https://github.com/puppeteer/puppeteer/releases) - [Changelog](https://github.com/puppeteer/puppeteer/blob/main/release-please-config.json) - [Commits](puppeteer/puppeteer@puppeteer-v21.9.0...puppeteer-v21.10.0) --- updated-dependencies: - dependency-name: puppeteer dependency-type: direct:production update-type: version-update:semver-minor dependency-group: test ... Signed-off-by: dependabot[bot] <support@github.com>
87d5566
to
6651002
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ran the usual npm install
to counteract Dependabot listing puppeteer
in dependencies
.
Missed the download by default of chrome shell
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added the necessary env variable to skip the download of the chrome-headless-shell
that Puppeteer now downloads automatically, but we don't use (we use new headless mode and take care of the binary download ourselves anyway).
Using HEADLESS=false npm run test
still works as intended in development.
This means this PR will need a second review, though. cc @alphagov/design-system-developers
@romaricpascal From puppeteer/puppeteer#11754 it looks like
Appears to be the case by looking through their options: |
@romaricpascal I've re-triggered one of the failed checks in this PR I'm seeing the same failures sporadically on other PRs, caused by |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@romaricpascal Morning! 👋
Do you mind checking if we can drop the new commit based on #4693 (comment)?
Then we can merge this
Missed that bit at the end, good spot! I'll remove that extra commit 😊 |
b03173d
to
6651002
Compare
…0503005ef Bump the test group with 1 update
Bumps the test group with 1 update: puppeteer.
Updates
puppeteer
from 21.9.0 to 21.10.0Release notes
Sourced from puppeteer's releases.
Commits
31a2339
chore: release main (#11756)9cd6673
fix: set viewport for element screenshots (#11772)2d8acd2
chore(deps): Bump the dependencies group with 6 updates (#11771)0dedc75
chore(deps): Bumpchromium-bidi
to0.5.6
(#11770)4e3a0d6
chore(deps-dev): Bump the dev-dependencies group with 3 updates (#11765)0242d22
chore(deps): Bump the all group with 5 updates (#11766)a91a9e1
build: disable license fixer (#11768)96b7af5
build: ESLint rule to check/add license headers (#11716)d085127
refactor: use generic implementation forwaitForNetworkIdle
(#11757)932b010
build: add a firefox:bidi:headful command (#11760)Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase
.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebase
will rebase this PR@dependabot recreate
will recreate this PR, overwriting any edits that have been made to it@dependabot merge
will merge this PR after your CI passes on it@dependabot squash and merge
will squash and merge this PR after your CI passes on it@dependabot cancel merge
will cancel a previously requested merge and block automerging@dependabot reopen
will reopen this PR if it is closed@dependabot close
will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot show <dependency name> ignore conditions
will show all of the ignore conditions of the specified dependency@dependabot ignore <dependency name> major version
will close this group update PR and stop Dependabot creating any more for the specific dependency's major version (unless you unignore this specific dependency's major version or upgrade to it yourself)@dependabot ignore <dependency name> minor version
will close this group update PR and stop Dependabot creating any more for the specific dependency's minor version (unless you unignore this specific dependency's minor version or upgrade to it yourself)@dependabot ignore <dependency name>
will close this group update PR and stop Dependabot creating any more for the specific dependency (unless you unignore this specific dependency or upgrade to it yourself)@dependabot unignore <dependency name>
will remove all of the ignore conditions of the specified dependency@dependabot unignore <dependency name> <ignore condition>
will remove the ignore condition of the specified dependency and ignore conditions