Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use KeyboardEvent.key over deprecated KeyboardEvent.keyCode in the Button component #4812

Merged
merged 2 commits into from
Mar 4, 2024
Merged

Use KeyboardEvent.key over deprecated KeyboardEvent.keyCode in the Button component #4812

merged 2 commits into from
Mar 4, 2024

Commits on Mar 4, 2024

  1. Use key over deprecated keyCode in Button 

    `KeyboardEvent.keyCode` is deprecated. All of the browsers that now run our JavaScript support the modern `KeyboardEvent.key` property.

Update the button component to using `KeyboardEvent.key` instead, removing the `KEY_SPACE` constant.
    @36degrees
    36degrees committed Mar 4, 2024
    Configuration menu
    Copy the full SHA
    aca1043 View commit details
    Browse the repository at this point in the history

  2. Document in CHANGELOG

    @36degrees
    36degrees committed Mar 4, 2024
    Configuration menu
    Copy the full SHA
    6fce6ed View commit details
    Browse the repository at this point in the history