Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

community/rethinkDB: add register settings for aarch64 #12096

Closed
wants to merge 1 commit into from

Conversation

ossdev07
Copy link
Contributor

added register settings for AARCH64 platform

Signed-off-by: ossdev07 ossdev@puresoftware.com

@ossdev07
Copy link
Contributor Author

@maxice8 @rnalrd Please have a look on this PR ..
Arm Version #41 will be fixed by these changes ..

@maxice8
Copy link
Contributor

maxice8 commented Nov 22, 2019

The commit title is wrong

@maxice8
Copy link
Contributor

maxice8 commented Nov 22, 2019

It is missing a pkgrel= bump

@ossdev07 ossdev07 changed the title [rethinkDB]: fixed crash issue on AARCH64 [rethinkDB]: added register settings for AARCH64 platform Nov 22, 2019
@ossdev07
Copy link
Contributor Author

The commit title is wrong

i could not understand completely ..
can you please suggest ?

@ossdev07
Copy link
Contributor Author

ossdev07 commented Nov 22, 2019

It is missing a pkgrel= bump

you mean my branch is not re based with alpine master ?

@maxice8
Copy link
Contributor

maxice8 commented Nov 22, 2019

community/rethinkdb: add register settings for aarch64

@maxice8
Copy link
Contributor

maxice8 commented Nov 22, 2019

you mean my branch is not re based with alpine master ?

you need to rebase against master and add 1 to the value of the variable pkgrel, you can use apkgrel -a community/rethinkdb

@ossdev07
Copy link
Contributor Author

you mean my branch is not re based with alpine master ?

you need to rebase against master and add 1 to the value of the variable pkgrel, you can use apkgrel -a community/rethinkdb

done
please verify ..

@ossdev07
Copy link
Contributor Author

ossdev07 commented Nov 25, 2019

@maxice8 @rnalrd please integrate this patch if things looks good to you

@maxice8
Copy link
Contributor

maxice8 commented Nov 25, 2019

Please use a proper commit community/rethinkdb: add register settings for aarch64

@ossdev07 ossdev07 changed the title [rethinkDB]: added register settings for AARCH64 platform community/rethinkDB: add register settings for aarch64 Nov 25, 2019
register settings are added for aarch64 platform

Signed-off-by: ossdev07 <ossdev@puresoftware.com>
@ossdev07
Copy link
Contributor Author

Please use a proper commit community/rethinkdb: add register settings for aarch64

done , please merge
Thanks ..

@maxice8
Copy link
Contributor

maxice8 commented Nov 25, 2019

Done

@algitbot
Copy link

Merged in 11c42c3 by @maxice8. Thanks for your contribution!

(This pull request has been closed automatically by GitHub PR Closer. If you think that it’s not resolved yet, please add a comment.)

@algitbot algitbot closed this Nov 25, 2019
@repo-lockdown
Copy link

repo-lockdown bot commented Jan 3, 2020

This repository does not accept Pull Requests (PR) anymore. Development has moved to https://gitlab.alpinelinux.org/alpine/aports Please signup and create a Merge Request (MR) instead. Sorry for the inconvenience caused.

@repo-lockdown repo-lockdown bot locked and limited conversation to collaborators Jan 3, 2020
algitbot pushed a commit that referenced this pull request Nov 11, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
R-community Community repository
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants