Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make binary installable #216

Closed
prestonvasquez opened this issue Oct 4, 2022 · 9 comments · Fixed by #245, #257, #260, #261 or #263
Closed

Make binary installable #216

prestonvasquez opened this issue Oct 4, 2022 · 9 comments · Fixed by #245, #257, #260, #261 or #263
Labels
architecture hacktoberfest

Comments

@prestonvasquez
Copy link
Contributor

prestonvasquez commented Oct 4, 2022 •
edited
Loading

Need to

  1. move the cmd/gidari.go file to "cmd/gidari/gidari.go".
  2. remove the cmd/bash-completion.sh script
  3. remove reference to bash completion in "cmd/gidari/gidari.go"

Need to add the following to the README.md file under "Installation":

go install github.com/alpine-hodler/gidari/cmd/gidari@latest

Gidari is not currently available as a library. Library support will be investigated in Issue #214
@prestonvasquez
Copy link
Contributor Author

@Himanshu664 do you want this one?

@prestonvasquez prestonvasquez changed the title Fill in the "Installation" section of the README.md Make binary installable Oct 4, 2022
@gauravgahlot
Copy link
Contributor

@prestonvasquez I would like to take it.

@himanshu-malviya15
Copy link

@gauravgahlot I am working on it

@gauravgahlot
Copy link
Contributor

Ah, alright. It's unassigned, hence the confusion.

@prestonvasquez prestonvasquez removed the question Further information is requested label Oct 4, 2022
himanshu-malviya15 pushed a commit to himanshu-malviya15/gidari that referenced this issue Oct 4, 2022
Changes as per issue alpstable#216
7ec178c
@himanshu-malviya15 himanshu-malviya15 mentioned this issue Oct 4, 2022
Closed
@himanshu-malviya15
Copy link

@prestonvasquez please review

@himanshu-malviya15 himanshu-malviya15 removed their assignment Oct 4, 2022
@prestonvasquez
Copy link
Contributor Author

@gauravgahlot Would you still like to do this?

@gauravgahlot
Copy link
Contributor

Sure.

@proffapt
Copy link

proffapt commented Oct 7, 2022

the readme update part is out of the script right?

@gauravgahlot gauravgahlot mentioned this issue Oct 7, 2022
Merged
@prestonvasquez
Copy link
Contributor Author

@proffapt Yes, sorry I've been out of town the last few days.

This was referenced Oct 11, 2022
Merged
Merged
Merged
Merged
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
architecture hacktoberfest
Projects
No open projects
Gidari MVP
Status: Done
Milestone
No milestone
4 participants
@prestonvasquez @gauravgahlot @himanshu-malviya15 @proffapt