Fix inconsistencies with disabled form elements #86
+5
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
background would also overwrite background-image, hiding the icons when the inputs where disabled.
Without this, it is impossible to tell checked and unchecked controls apart when they are disabled.
The missing :not(:disabled) meant that the background color did not match with other controls in disabled state.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes three things I found odd with how disabled form elements are rendered:
background, which overwrotebackground-imageas well)I've added some notes in the actual commits, if you want me to squash it into one commit or include the changes to
dist/, please let me know.