Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature: Add parsing support for barrier/reset/delay/duration #52

Merged
merged 7 commits into from
Sep 25, 2024

Conversation

kshyatt-aws
Copy link
Member

Issue #, if available: N/A

Description of changes: Allows parsing of QASM files that use reset, barrier, delay and duration instructions. Currently these don't actually apply the reset or barrier (they are no-ops) but this would allow proper implementation of these operations.

Testing done: Unit tests passed locally.

Merge Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your pull request.

General

Tests

  • I have added tests that prove my fix is effective or that my feature works (if appropriate)
  • I have checked that my tests are not configured for a specific region or account (if appropriate)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@kshyatt-aws kshyatt-aws requested a review from a team as a code owner September 24, 2024 18:08
rmshaffer
rmshaffer previously approved these changes Sep 24, 2024
src/Quasar.jl Show resolved Hide resolved
test/test_openqasm3.jl Show resolved Hide resolved
Copy link

codecov bot commented Sep 24, 2024

Codecov Report

Attention: Patch coverage is 96.20253% with 3 lines in your changes missing coverage. Please review.

Project coverage is 99.18%. Comparing base (23991af) to head (2c9c9c5).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
src/dm_simulator.jl 0.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #52      +/-   ##
==========================================
+ Coverage   99.13%   99.18%   +0.04%     
==========================================
  Files          22       22              
  Lines        3367     3423      +56     
==========================================
+ Hits         3338     3395      +57     
+ Misses         29       28       -1     
Flag Coverage Δ
99.18% <96.20%> (+0.04%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kshyatt-aws kshyatt-aws merged commit 4780fdf into main Sep 25, 2024
13 of 14 checks passed
@kshyatt-aws kshyatt-aws deleted the ksh/no-ops branch September 25, 2024 00:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants