Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add force flag for import testing #864

Merged
merged 2 commits into from
Jan 29, 2024
Merged

fix: add force flag for import testing #864

merged 2 commits into from
Jan 29, 2024

Conversation

math411
Copy link
Contributor

@math411 math411 commented Jan 29, 2024

Issue #, if available:

Description of changes:

Testing done:

Merge Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your pull request.

General

Tests

  • I have added tests that prove my fix is effective or that my feature works (if appropriate)
  • I have checked that my tests are not configured for a specific region or account (if appropriate)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@math411 math411 requested a review from shpface January 29, 2024 20:54
@math411 math411 requested a review from a team as a code owner January 29, 2024 20:54
@math411 math411 marked this pull request as draft January 29, 2024 20:54
@math411 math411 marked this pull request as ready for review January 29, 2024 21:10
Copy link

codecov bot commented Jan 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (cc28083) 100.00% compared to head (f557e61) 100.00%.

Additional details and impacted files
@@            Coverage Diff            @@
##              main      #864   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          129       129           
  Lines         8532      8532           
  Branches      1908      1908           
=========================================
  Hits          8532      8532           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@math411 math411 merged commit 343f2be into main Jan 29, 2024
24 checks passed
@math411 math411 deleted the mp_fix branch January 29, 2024 21:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants