Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean development files #128

Merged
merged 5 commits into from
Jan 21, 2022
Merged

Clean development files #128

merged 5 commits into from
Jan 21, 2022

Conversation

felladrin
Copy link
Collaborator

@felladrin felladrin commented Jan 20, 2022

Clean development files

There were too many development files and it was getting hard to maintain them all.

This PR brings the following changes:

  • Remove test-compose.yml as tests run just fine with docker-compose up -d minio (using docker-compose.yml).
  • Remove VS Code Dev Container configuration, as it was pretty outdated. Instructions from Readme were also removed.
  • Simplify Gitpod configuration. Now it makes use of docker-compose.yml and starts up much faster.
  • Update AdminIO-UI and AdminIO-API images.

Also, remove container cleanup task, as it was not matching the container name started by docker-compose.
@felladrin felladrin marked this pull request as draft January 21, 2022 07:55
@felladrin felladrin marked this pull request as ready for review January 21, 2022 08:39
Copy link
Collaborator

@BuJo BuJo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@aminueza aminueza merged commit 43dcc44 into master Jan 21, 2022
@aminueza aminueza deleted the update-devcontainer branch January 21, 2022 17:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants