Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Gitpod configuration #154

Merged
merged 2 commits into from
Feb 14, 2022
Merged

Update Gitpod configuration #154

merged 2 commits into from
Feb 14, 2022

Conversation

felladrin
Copy link
Collaborator

Update Gitpod configuration

This PR implements the following changes:

  • Ignore port 9001 used by MinIO Server Console, when opening the project on Gitpod, as this port is not meant to be opened in a browser.

@BuJo
Copy link
Collaborator

BuJo commented Feb 14, 2022

Oh sorry, I guess gitpod wasn't on my radar yet...

Copy link
Collaborator

@BuJo BuJo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, thank you :D ❤️

@felladrin
Copy link
Collaborator Author

Ah, no worries 😄 This is just for convenience, to avoid notifications / reduce the noise when opening the workspace on Gitpod: https://gitpod.io/#https://github.com/aminueza/terraform-provider-minio
Thanks for approving, @BuJo!

@felladrin felladrin merged commit ed819b6 into master Feb 14, 2022
@felladrin felladrin deleted the ignore-port-9001-on-gitpod branch February 14, 2022 11:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants