Ignore aws policy sort order for diffs #180
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BuJo
approved these changes
Mar 14, 2022
pjsier
force-pushed
the
minio-policy-order-117
branch
from
0cc9831
to
d56c661
Compare
|
@BuJo sounds great, just updated! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates dependencies to use hashicorp/awspolicyequivalence to ignore sort order inside policy JSON objects. It looks like it's a fork of the previous dependency used to fix the same issue in hashicorp/terraform-provider-aws.
I also added one small test to the test file added in #165. Happy to make any changes to this
Reference