Add minio_session_token configuration #362
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
felladrin
approved these changes
Oct 16, 2022
There was a problem hiding this comment.
Thanks for implementing it, @pjsier!
Looks good to me, and I also see it matches what @BuJo mentioned on that issue.
I'm approving it and a patch-release will be published soon.
|
Yeah, this looks very fine for me as well. Thanks @pjsier and @felladrin for reviewing! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds
minio_session_tokenconfiguration option to support using temporary credentials. I followed the recommended strategy from the issue comment, and I also updated theminioAdmincreation to useNewWithOptionsto support configuring credentials with a session token. I didn't see anywhere else that needed updating, but I may have missed something.The tests are passing, but I'm happy to add more. I just didn't see a clear place where provider configuration tests would fit. Let me know if there are any changes I should make, thanks!
Closing issues