fix: check response code when response code is 200 (#349)

amplitude · Feb 3, 2023 · 19f6f5d · 19f6f5d
1 parent 174c985
commit 19f6f5d
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/src/main/java/com/amplitude/api/AmplitudeClient.java b/src/main/java/com/amplitude/api/AmplitudeClient.java
@@ -2271,7 +2271,7 @@ protected void makeEventUploadPostRequest(Call.Factory client, String events, fi
         try {
             Response response = client.newCall(request).execute();
             String stringResponse = response.body().string();
-            if (stringResponse.equals("success")) {
+            if (response.code() == 200 || stringResponse.equals("success")) {
                 uploadSuccess = true;
                 logThread.post(new Runnable() {
                     @Override

diff --git a/src/test/java/com/amplitude/api/AmplitudeClientTest.java b/src/test/java/com/amplitude/api/AmplitudeClientTest.java
@@ -906,8 +906,8 @@ public void testSaveEventLogic() {
         // unsent events will be threshold (+1 for start session)
         assertEquals(getUnsentEventCount(), Constants.EVENT_UPLOAD_THRESHOLD + 1);
 
-        server.enqueue(new MockResponse().setBody("invalid_api_key"));
-        server.enqueue(new MockResponse().setBody("bad_checksum"));
+        server.enqueue(new MockResponse().setResponseCode(400).setBody("invalid_api_key"));
+        server.enqueue(new MockResponse().setResponseCode(400).setBody("bad_checksum"));
         ShadowLooper httpLooper = Shadows.shadowOf(amplitude.httpThread.getLooper());
         httpLooper.runToEndOfTasks();