Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Cleanup test cookies #381

Merged
merged 7 commits into from
Apr 30, 2021
Merged

fix: Cleanup test cookies #381

merged 7 commits into from
Apr 30, 2021

Conversation

jooohhn
Copy link
Contributor

@jooohhn jooohhn commented Apr 26, 2021

Summary

Checklist

  • Does your PR title have the correct title format?
  • Does your PR have a breaking change?: NO

@jooohhn jooohhn requested a review from ajhorst April 26, 2021 06:45
Copy link
Contributor

@kelvin-lu kelvin-lu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm after the console removals.

Do you have plans to add unit tests to this?

src/base-cookie.js Outdated Show resolved Hide resolved
src/base-cookie.js Outdated Show resolved Hide resolved
@jooohhn jooohhn merged commit 9d8ecc3 into main Apr 30, 2021
@jooohhn jooohhn deleted the fix-cleanup-test-cookies branch April 30, 2021 16:53
github-actions bot pushed a commit that referenced this pull request Apr 30, 2021
## [8.2.1](v8.2.0...v8.2.1) (2021-04-30)

### Bug Fixes

*  Cleanup test cookies ([#381](#381)) ([9d8ecc3](9d8ecc3))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Amplitude is adding too many cookies causing 400 Bad Request errors
3 participants