Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Clear Storage API #396

Merged
merged 5 commits into from
May 26, 2021
Merged

feat: Clear Storage API #396

merged 5 commits into from
May 26, 2021

Conversation

jooohhn
Copy link
Contributor

@jooohhn jooohhn commented May 26, 2021

Summary

Adds an API to AmplitudeClient clearStorage that wipes user metadata. Escape hatch to help weird edge cases where user's datastorage is malformed somehow.

Checklist

  • Does your PR title have the correct title format?
  • Does your PR have a breaking change?: NO

@jooohhn jooohhn requested a review from ajhorst May 26, 2021 16:56
}
}
if (!str) false;
return true;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit, here you can use ``return !!str` for the same effect

Copy link
Contributor

@ajhorst ajhorst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

one small change request, otherwise looks good to me

@jooohhn jooohhn merged commit e8cb8b7 into main May 26, 2021
@jooohhn jooohhn deleted the feat-clear-storage branch May 26, 2021 21:25
github-actions bot pushed a commit that referenced this pull request May 26, 2021
# [8.3.0](v8.2.3...v8.3.0) (2021-05-26)

### Features

* Clear Storage API ([#396](#396)) ([e8cb8b7](e8cb8b7))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants