fix: removed unused getUserId() (#114)

amplitude · Mar 17, 2022 · 3e512c3 · 3e512c3
1 parent 945af2f
commit 3e512c3
Show file tree

Hide file tree

Showing 5 changed files with 0 additions and 26 deletions.
diff --git a/android/src/main/java/com/amplitude/reactnative/AmplitudeReactNativeModule.java b/android/src/main/java/com/amplitude/reactnative/AmplitudeReactNativeModule.java
@@ -177,14 +177,6 @@ public void setUserId(String instanceName, String userId, Promise promise) {
         }
     }
 
-    @ReactMethod
-    public void getUserId(String instanceName, Promise promise) {
-        AmplitudeClient client = Amplitude.getInstance(instanceName);
-        synchronized (client) {
-            promise.resolve(client.getUserId());
-        }
-    }
-
     @ReactMethod
     public void setServerUrl(String instanceName, String serverUrl, Promise promise) {
         AmplitudeClient client = Amplitude.getInstance(instanceName);

diff --git a/ios/AmplitudeReactNative.m b/ios/AmplitudeReactNative.m
@@ -26,8 +26,6 @@ @interface RCT_EXTERN_MODULE(AmplitudeReactNative, NSObject)
 
 RCT_EXTERN_METHOD(setUserId:(NSString *)instanceName userId:(NSString *)userId resolver:(RCTPromiseResolveBlock)resolve rejecter:(RCTPromiseRejectBlock)reject)
 
-RCT_EXTERN_METHOD(getUserId:(NSString *)instanceName resolver:(RCTPromiseResolveBlock)resolve rejecter:(RCTPromiseRejectBlock)reject)
-
 RCT_EXTERN_METHOD(setServerUrl:(NSString *)instanceName serverUrl:(NSString *)serverUrl resolver:(RCTPromiseResolveBlock)resolve rejecter:(RCTPromiseRejectBlock)reject)
 
 RCT_EXTERN_METHOD(logEvent:(NSString *)instanceName eventType:(NSString *)eventType resolver:(RCTPromiseResolveBlock)resolve rejecter:(RCTPromiseRejectBlock)reject)

diff --git a/ios/AmplitudeReactNative.swift b/ios/AmplitudeReactNative.swift
@@ -124,13 +124,6 @@ class ReactNative: NSObject {
         resolve(true)
     }
 
-    @objc
-    func getUserId(_ instanceName: String,
-                   resolver resolve: RCTPromiseResolveBlock,
-                   rejecter reject: RCTPromiseRejectBlock) -> Void {
-        resolve(Amplitude.instance(withName: instanceName).getUserId())
-    }
-
     @objc
     func setServerUrl(_ instanceName: String,
                       serverUrl: String,

diff --git a/src/index.ts b/src/index.ts
@@ -200,14 +200,6 @@ export class Amplitude {
     return AmplitudeReactNative.setUserId(this.instanceName, userId);
   }
 
-  /**
-   * Fetches user id.
-   * @returns user id.
-   */
-  getUserId(): Promise<string> {
-    return AmplitudeReactNative.getUserId(this.instanceName);
-  }
-
   /**
    * Customize the destination for server url.
    *

diff --git a/src/types.ts b/src/types.ts
@@ -42,7 +42,6 @@ export interface AmplitudeReactNativeModule {
     useDynamicConfig: boolean,
   ): Promise<boolean>;
   setUserId(instanceName: string, userId: string | null): Promise<boolean>;
-  getUserId(instanceName: string): Promise<string>;
   setServerUrl(instanceName: string, serverUrl: string): Promise<boolean>;
   logRevenueV2(
     instanceName: string,