Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add boolean value to identify #155

Merged
merged 1 commit into from
Dec 21, 2022
Merged

Conversation

liuyang1520
Copy link
Contributor

Notes

  • feat: add boolean value to identify

Currently, when user tries to run following code, it will fall to the unset block:

const identify = new Identify();
identify.set(“test”, true);
await Amplitude.getInstance().identify(identify);

The boolean type is missing, this PR adds it based on the Android SDK's support: https://github.com/amplitude/Amplitude-Android/blob/main/src/main/java/com/amplitude/api/Identify.java#L51.

Tests

  • local test

@liuyang1520 liuyang1520 merged commit b5eec9a into main Dec 21, 2022
@liuyang1520 liuyang1520 deleted the add-boolean-value-to-identify branch December 21, 2022 23:05
github-actions bot pushed a commit that referenced this pull request Dec 21, 2022
# [2.17.0](v2.16.2...v2.17.0) (2022-12-21)

### Features

* add boolean value to identify ([#155](#155)) ([b5eec9a](b5eec9a))
@github-actions
Copy link

🎉 This PR is included in version 2.17.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants