Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: disable network checker if navigator is unavailable #876

Merged
merged 2 commits into from
Sep 18, 2024
Merged

fix: disable network checker if navigator is unavailable #876

merged 2 commits into from
Sep 18, 2024

Conversation

izaaz
Copy link
Contributor

@izaaz izaaz commented Sep 17, 2024

Summary

Check if navigator is available before using it for network connectivity checks

Checklist

  • Does your PR title have the correct title format?
  • Does your PR have a breaking change?:

@izaaz izaaz requested a review from Mercy811 September 17, 2024 04:05
@izaaz izaaz mentioned this pull request Sep 17, 2024
Closed
1 task
johnf
johnf approved these changes Sep 17, 2024
View reviewed changes
Copy link

@johnf johnf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

packages/analytics-browser/src/plugins/network-connectivity-checker.ts Show resolved Hide resolved
Mercy811
Mercy811 approved these changes Sep 18, 2024
View reviewed changes
Copy link
Contributor

@Mercy811 Mercy811 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @izaaz for fixing when navigator is not available when analytics-browser is pulled in the sever side rendering part of a next.js all.

@izaaz izaaz merged commit c64df83 into main Sep 18, 2024
3 checks passed
@izaaz izaaz deleted the AMP-109591/ssr_checks branch September 18, 2024 21:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@johnf johnf johnf approved these changes

@Mercy811 Mercy811 Mercy811 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@izaaz @johnf @Mercy811