Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: assign deviceId correctly on new device #492

Merged
merged 3 commits into from
Apr 5, 2024
Merged

fix: assign deviceId correctly on new device #492

merged 3 commits into from
Apr 5, 2024
+8 −7

Conversation

bgiori
Copy link
Collaborator

@bgiori bgiori commented Apr 5, 2024

Summary

Checklist

  • Does your PR title have the correct title format?
  • Does your PR have a breaking change?:

@bgiori bgiori marked this pull request as ready for review April 5, 2024 15:34
@bgiori bgiori changed the title chore: remove podfile validateion from test action chore: remove podfile validation from test action Apr 5, 2024
@bgiori bgiori changed the title chore: remove podfile validation from test action fix: assign deviceId correctly on new device Apr 5, 2024
@bgiori bgiori merged commit a200db0 into main Apr 5, 2024
3 checks passed
@bgiori bgiori deleted the no-pod-validate branch April 5, 2024 17:50
github-actions bot pushed a commit that referenced this pull request Apr 5, 2024
@amplitude-sdk-bot
chore(release): 8.19.1 [skip ci]
b25fab0 
## [8.19.1](v8.19.0...v8.19.1) (2024-04-05)

### Bug Fixes

* assign deviceId correctly on new device ([#492](#492)) ([a200db0](a200db0))
* initialize device info before generating the device ID ([#491](#491)) ([7960a7e](7960a7e))
@github-actions GitHub Actions
Copy link

github-actions bot commented Apr 5, 2024

🎉 This PR is included in version 8.19.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@crleona crleona crleona approved these changes

Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bgiori @crleona