Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow dragging CTA button within the CTA block #2824

Merged
merged 51 commits into from
Aug 13, 2019
Merged

Allow dragging CTA button within the CTA block #2824

merged 51 commits into from
Aug 13, 2019

Commits on Jul 16, 2019

  1. Add BlockMover around the CTA button.

    @miina
    miina committed Jul 16, 2019
    Configuration menu
    Copy the full SHA
    7b0200c View commit details
    Browse the repository at this point in the history

  2. Adjust style to position absolute.

    @miina
    miina committed Jul 16, 2019
    Configuration menu
    Copy the full SHA
    df17c17 View commit details
    Browse the repository at this point in the history

  3. Apply relevant params to the CTA button.

    @miina
    miina committed Jul 16, 2019
    Configuration menu
    Copy the full SHA
    09c03ca View commit details
    Browse the repository at this point in the history

  4. Use unique ID-s.

    @miina
    miina committed Jul 16, 2019
    Configuration menu
    Copy the full SHA
    d29b9fa View commit details
    Browse the repository at this point in the history

  5. Make drop work.

    @miina
    miina committed Jul 16, 2019
    Configuration menu
    Copy the full SHA
    7f9d76f View commit details
    Browse the repository at this point in the history

  6. Split up drop method for movable vs CTA button

    @miina
    miina committed Jul 16, 2019
    Configuration menu
    Copy the full SHA
    ecd5a35 View commit details
    Browse the repository at this point in the history

  7. Adjust style for the top border.

    @miina
    miina committed Jul 16, 2019
    Configuration menu
    Copy the full SHA
    38c58ba View commit details
    Browse the repository at this point in the history

  8. Adjust the style to remove the margin between page borders and CTA.

    @miina
    miina committed Jul 16, 2019
    Configuration menu
    Copy the full SHA
    d9afd3a View commit details
    Browse the repository at this point in the history

  9. Improve clone position.

    @miina
    miina committed Jul 16, 2019
    Configuration menu
    Copy the full SHA
    c3c75e1 View commit details
    Browse the repository at this point in the history

  10. Improve variable names.

    @miina
    miina committed Jul 16, 2019
    Configuration menu
    Copy the full SHA
    c3b901b View commit details
    Browse the repository at this point in the history

  11. Fix undefined variable.

    @miina
    miina committed Jul 16, 2019
    Configuration menu
    Copy the full SHA
    480ab97 View commit details
    Browse the repository at this point in the history

Commits on Jul 17, 2019

  1. Fix passing blockName. 

    Adjust drop logic.
    @miina
    miina committed Jul 17, 2019
    Configuration menu
    Copy the full SHA
    fd43315 View commit details
    Browse the repository at this point in the history

  2. More fixes to the drop and drag preciseness.

    @miina
    miina committed Jul 17, 2019
    Configuration menu
    Copy the full SHA
    7fcf395 View commit details
    Browse the repository at this point in the history

  3. Restrict dragging CTA button over the top limit.

    @miina
    miina committed Jul 17, 2019
    Configuration menu
    Copy the full SHA
    462f1d2 View commit details
    Browse the repository at this point in the history

  4. JS fixes.

    @miina
    miina committed Jul 17, 2019
    Configuration menu
    Copy the full SHA
    41fe287 View commit details
    Browse the repository at this point in the history

  5. Update wrapper selector to improve the drop preciseness.

    @miina
    miina committed Jul 17, 2019
    Configuration menu
    Copy the full SHA
    c4648b5 View commit details
    Browse the repository at this point in the history

  6. Update dropzone height to cover the whole page.

    @miina
    miina committed Jul 17, 2019
    Configuration menu
    Copy the full SHA
    0cbe34b View commit details
    Browse the repository at this point in the history

  7. Adjust logic not to break existing blocks. 

    Improve styling.

Apply style in FE.
    @miina
    miina committed Jul 17, 2019
    Configuration menu
    Copy the full SHA
    2b7d565 View commit details
    Browse the repository at this point in the history

  8. Hide link while dragging.

    @miina
    miina committed Jul 17, 2019
    Configuration menu
    Copy the full SHA
    78e4a46 View commit details
    Browse the repository at this point in the history

  9. Remove alignment options.

    @miina
    miina committed Jul 17, 2019
    Configuration menu
    Copy the full SHA
    5dfe85e View commit details
    Browse the repository at this point in the history

  10. Add missing propTypes.

    @miina
    miina committed Jul 17, 2019
    Configuration menu
    Copy the full SHA
    78249e5 View commit details
    Browse the repository at this point in the history

  11. Style adjustments for showing grab handle.

    @miina
    miina committed Jul 17, 2019
    Configuration menu
    Copy the full SHA
    47bb13d View commit details
    Browse the repository at this point in the history

  12. Remove alignment leftovers from CSS, too.

    @miina
    miina committed Jul 17, 2019
    Configuration menu
    Copy the full SHA
    bb504ff View commit details
    Browse the repository at this point in the history

  13. Update templates. 

    Fix proptypes.
    @miina
    miina committed Jul 17, 2019
    Configuration menu
    Copy the full SHA
    268b4f9 View commit details
    Browse the repository at this point in the history

  14. Move drop logics into one method.

    @miina
    miina committed Jul 17, 2019
    Configuration menu
    Copy the full SHA
    c24ce0c View commit details
    Browse the repository at this point in the history

  15. Update jsDocs.

    @miina
    miina committed Jul 17, 2019
    Configuration menu
    Copy the full SHA
    9f9fe9a View commit details
    Browse the repository at this point in the history

  16. Use variables for attribute object keys.

    @miina
    miina committed Jul 17, 2019
    Configuration menu
    Copy the full SHA
    073448b View commit details
    Browse the repository at this point in the history

Commits on Jul 18, 2019

  1. Start adding e2e tests.

    @miina
    miina committed Jul 18, 2019
    Configuration menu
    Copy the full SHA
    de138ab View commit details
    Browse the repository at this point in the history

  2. Move folder.

    @miina
    miina committed Jul 18, 2019
    Configuration menu
    Copy the full SHA
    15df39e View commit details
    Browse the repository at this point in the history

  3. Fix some JS issues.

    @miina
    miina committed Jul 18, 2019
    Configuration menu
    Copy the full SHA
    374beb2 View commit details
    Browse the repository at this point in the history

Commits on Jul 19, 2019

  1. Start adding deprecated block.

    @miina
    miina committed Jul 19, 2019
    Configuration menu
    Copy the full SHA
    69fed5b View commit details
    Browse the repository at this point in the history

  2. Update deprecation logic. 

    Remove not working e2e test.
    @miina
    miina committed Jul 19, 2019
    Configuration menu
    Copy the full SHA
    4853c02 View commit details
    Browse the repository at this point in the history

  3. Move folders.

    @miina
    miina committed Jul 19, 2019
    Configuration menu
    Copy the full SHA
    8118ac9 View commit details
    Browse the repository at this point in the history

  4. Add propTypes for deprecated save function.

    @miina
    miina committed Jul 19, 2019
    Configuration menu
    Copy the full SHA
    f1f0cdf View commit details
    Browse the repository at this point in the history

Commits on Jul 22, 2019

  1. Enable Stories before running the tests.

    @miina
    miina committed Jul 22, 2019
    Configuration menu
    Copy the full SHA
    ad13459 View commit details
    Browse the repository at this point in the history

Commits on Aug 6, 2019

  1. Merge develop & resolve conflicts.

    @miina
    miina committed Aug 6, 2019
    Configuration menu
    Copy the full SHA
    efb0ae6 View commit details
    Browse the repository at this point in the history

  2. Fix CSS.

    @miina
    miina committed Aug 6, 2019
    Configuration menu
    Copy the full SHA
    be29219 View commit details
    Browse the repository at this point in the history

  3. Adjust tests based on develop changes.

    @miina
    miina committed Aug 6, 2019
    Configuration menu
    Copy the full SHA
    87f0b2d View commit details
    Browse the repository at this point in the history

  4. Add test for CTA block validation error.

    @miina
    miina committed Aug 6, 2019
    8 Configuration menu
    Copy the full SHA
    7e30dbd View commit details
    Browse the repository at this point in the history

  5. Add double click editing for CTA block, too.

    @miina
    miina committed Aug 6, 2019
    Configuration menu
    Copy the full SHA
    46dec05 View commit details
    Browse the repository at this point in the history

  6. Update tests.

    @miina
    miina committed Aug 6, 2019
    Configuration menu
    Copy the full SHA
    847e7ec View commit details
    Browse the repository at this point in the history

Commits on Aug 7, 2019

  1. Merge develop & resolve conflicts.

    @miina
    miina committed Aug 7, 2019
    Configuration menu
    Copy the full SHA
    fb94cb0 View commit details
    Browse the repository at this point in the history

  2. Move CTA tests file.

    @miina
    miina committed Aug 7, 2019
    Configuration menu
    Copy the full SHA
    34a7f84 View commit details
    Browse the repository at this point in the history

  3. Bump the template version.

    @miina
    miina committed Aug 7, 2019
    Configuration menu
    Copy the full SHA
    dbc5f30 View commit details
    Browse the repository at this point in the history

Commits on Aug 8, 2019

  1. Fix missing anchor.

    @miina
    miina committed Aug 8, 2019
    Configuration menu
    Copy the full SHA
    c1c792e View commit details
    Browse the repository at this point in the history

  2. Fix duplicate background color.

    @miina
    miina committed Aug 8, 2019
    Configuration menu
    Copy the full SHA
    fd9c496 View commit details
    Browse the repository at this point in the history

  3. Use RawHTML when displaying not editable content.

    @miina
    miina committed Aug 8, 2019
    Configuration menu
    Copy the full SHA
    eb9daeb View commit details
    Browse the repository at this point in the history

  4. Merge remote-tracking branch 'origin/develop' into 2781-dragging_cta_… 

    …button
    @miina
    miina committed Aug 8, 2019
    Configuration menu
    Copy the full SHA
    4a71916 View commit details
    Browse the repository at this point in the history

  5. Fix issues from merging.

    @miina
    miina committed Aug 8, 2019
    Configuration menu
    Copy the full SHA
    bf27a94 View commit details
    Browse the repository at this point in the history

Commits on Aug 13, 2019

  1. Merge develop.

    @miina
    miina committed Aug 13, 2019
    Configuration menu
    Copy the full SHA
    4c36cba View commit details
    Browse the repository at this point in the history

  2. Remove duplicate import.

    @miina
    miina committed Aug 13, 2019
    Configuration menu
    Copy the full SHA
    a259b30 View commit details
    Browse the repository at this point in the history