Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix phantomjs versioning on Travis #10305

Merged
merged 38 commits into from
Jul 11, 2017
Merged

Fix phantomjs versioning on Travis #10305

merged 38 commits into from
Jul 11, 2017

Conversation

rsimha
Copy link
Contributor

@rsimha rsimha commented Jul 7, 2017 •
edited
Loading

Fixes #10361

@rsimha rsimha requested a review from erwinmombay July 7, 2017 16:46
@rsimha rsimha self-assigned this Jul 7, 2017
@rsimha rsimha changed the title Install phantomjs on Travis so it needn't be reinstalled during testing Register phantomjs so it needn't be reinstalled during testing Jul 7, 2017
@rsimha rsimha changed the title Register phantomjs so it needn't be reinstalled during testing Make correct version of phantomjs visible to Travis Jul 11, 2017
@rsimha rsimha changed the title Make correct version of phantomjs visible to Travis Fix phantomjs versioning on Travis Jul 11, 2017
@rsimha rsimha mentioned this pull request Jul 11, 2017
Closed
@rsimha rsimha merged commit 4e6fa8d into ampproject:master Jul 11, 2017
@rsimha rsimha deleted the 2017-07-07-Phantomjs branch July 11, 2017 20:36
@rsimha rsimha mentioned this pull request Jan 9, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@erwinmombay erwinmombay erwinmombay approved these changes

Assignees

@rsimha rsimha

Labels
cla: yes PR use: In Beta / Experimental PR use: In Stable
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@rsimha @erwinmombay @googlebot @ampprojectbot