Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 Rollback esbuild to 0.13.6 #36599

Merged
merged 1 commit into from
Oct 26, 2021
Merged

🐛 Rollback esbuild to 0.13.6 #36599

merged 1 commit into from
Oct 26, 2021

Conversation

rsimha
Copy link
Contributor

@rsimha rsimha commented Oct 26, 2021

Install is broken for 0.13.9 on node 16. See evanw/esbuild#1711

image

@rsimha rsimha enabled auto-merge (squash) October 26, 2021 19:41
@evanw
Copy link

evanw commented Oct 26, 2021

I just saw this PR via the link-back but I can't reproduce the problem. Do you have any more information or insight? It's unclear why esbuild-darwin-64 is not installed since it's a dependency of the esbuild package, so it should have been installed.

@rsimha rsimha disabled auto-merge October 26, 2021 19:56
@rsimha rsimha merged commit fc4020e into ampproject:main Oct 26, 2021
@rsimha rsimha deleted the 2021-10-26-Esbuild branch October 26, 2021 19:57
@rsimha
Copy link
Contributor Author

rsimha commented Oct 26, 2021

Hi @evanw, thanks for checking in, and nice to meet you 😃

Our project uses the LTS version of node which means we switched from node v14 / npm v6 to the new LTS release node v16 / npm v8. We noticed that a clean install of esbuild in our project started failing soon as the new LTS version was rolled out. Some of us had luck attempting the install a second time, while others didn't.

My suspicion is this is due to how npm v8 is interacting with the esbuild install script (maybe there's a race?), but I'm not 100% sure.

image

@rsimha
Copy link
Contributor Author

rsimha commented Oct 27, 2021

Update: The install issue appears to have gone away today, which leads me to believe it was a temporary npm issue. (Related to the node 16 / npm 8 LTS release?)

I've rolled forward to 0.13.9 via #36615. Clean install worked locally.

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants