Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(WIP) zod-openapi: use defu instead of ts-deepmerge #187

Closed
wants to merge 1 commit into from

Conversation

zsilbi
Copy link

@zsilbi zsilbi commented Feb 10, 2024

Hello!

I get ts_deepmerge_1.default is not a function errors when running a bundled version of my project with workerd. The root cause of this is that the merge function from ts-deepmerge is exported in a very weird way, and the bundler can't really figure out how to include it properly.

image

I propose a switch from ts-deepmerge to defu

defu has a different order of priority for the passed parameters than ts-deepmerge. The left-most parameter is the highest. Can this be an issue?

Thanks,
zsilbi

Copy link

nx-cloud bot commented Feb 10, 2024

☁️ Nx Cloud Report

CI is running/has finished running commands for commit d1cf051. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution


✅ Successfully ran 2 targets

Sent with 💌 from NxCloud.

@zsilbi zsilbi changed the title zod-openapi: use defu instead of ts-deepmerge (WIP) zod-openapi: use defu instead of ts-deepmerge Feb 10, 2024
@zsilbi zsilbi closed this Apr 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant