Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add configuration file input #299

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Add configuration file input #299

wants to merge 2 commits into from

Conversation

p5
Copy link

@p5 p5 commented Apr 5, 2024

Closes #217

Adds a new input parameter to allow the user to specify the location of a config file.
This PR includes some tests to ensure the correct flags are passed into Grype, and updates the README.md.

I am unsure what else to add to the tests, or how to actually test that parameters in the config files are working. Hopefully I can have some guidance here.

I have chosen the same naming convention as the Syft action.

p5 added 2 commits April 5, 2024 18:49
Signed-off-by: Robert Sturla <robertsturla@outlook.com>
Signed-off-by: Robert Sturla <robertsturla@outlook.com>
@p5 p5 changed the title Add configuration file flag input Add configuration file input Apr 5, 2024
@p5 p5 marked this pull request as ready for review April 5, 2024 17:53
@p5 p5 marked this pull request as draft April 5, 2024 21:02
@p5 p5 marked this pull request as ready for review April 5, 2024 21:47
@kzantow kzantow closed this Jul 31, 2024
@kzantow kzantow reopened this Jul 31, 2024
@kzantow
Copy link
Contributor

kzantow commented Jul 31, 2024

Hey @p5, sorry for the delay here. Is this still something you are interested in getting merged? I think to get this merged it would be useful to have a test validating the CLI option (like these).

However, I should also note that today there are already a couple other ways to configure grype-specific parameters in the action using environment variables, a couple examples are passing a configuration file using environment variables:

      - uses: anchore/scan-action@main
        with:
          image: alpine:3.15
        env:
          GRYPE_CONFIG: ./my-config.yml

... or simply setting specific parameters using the grype environment variables:

      - uses: anchore/scan-action@main
        with:
          image: alpine:3.15
        env:
          GRYPE_ONLY_FIXED: true

... would either of these suffice or would you prefer adding an explicit configuration option?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add config as an option
2 participants