fix: goroutine leak with docker daemon #183
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iAklis
changed the title
|
Hey @iAklis I updated the PR based on feedback in the issue -- that being said, you can treat this as a suggested path... if you don't like this approach we can chat further. Does the branch with the current adjustments also fix the behavior you're seeing? (I also force pushed to rebase the branch on main) |
…communicating with the Docker daemon via the Unix socket. Previously, these connections were not being properly released, leading to a growing number of goroutines over time. The solution involves modifying the http.Transport of the Docker client to disable keep-alives and set an idle connection timeout. This effectively closes idle connections, thereby preventing the goroutine leak. Changes made: - Added `DisableKeepAlives: true` and `IdleConnTimeout: 10 * time.Second` to the http.Transport of the Docker client. Resolves: anchore#182 Signed-off-by: Aklis Chen <chenpinwei@gmail.com> Signed-off-by: Alex Goodman <wagoodman@users.noreply.github.com>
Signed-off-by: Alex Goodman <wagoodman@users.noreply.github.com>
wagoodman
force-pushed
the
fix-goroutine-leak
branch
from
c315972
to
97f3237
Compare
|
@wagoodman Yes, it works. |
wagoodman
changed the title
Signed-off-by: Alex Goodman <wagoodman@users.noreply.github.com>
wagoodman
approved these changes
Jul 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit addresses a goroutine leak that occurs when continuously communicating with the Docker daemon via the Unix socket. Previously, these connections were not being properly released, leading to a growing number of goroutines over time.
The first solution with 4cf42ac involved modifying the http.Transport of the Docker client to disable keep-alives and set an idle connection timeout. This effectively closes idle connections, thereby preventing the goroutine leak.
Based off of comments on the issue this was pivoted to close the client after the provider is used for the first time.
Resolves: #182