Prop 'type' doesn't change keyboard type #68
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
September 9, 2024 17:06
|
@BogdanGorelkin thank you, I'll test and merge |
|
bumping this |
anday013
reviewed
Sep 15, 2024
src/OtpInput/OtpInput.tsx
Outdated
| @@ -5,7 +5,7 @@ import { OtpInputProps, OtpInputRef } from "./OtpInput.types"; | |||
| import { VerticalStick } from "./VerticalStick"; | |||
| import { useOtpInput } from "./useOtpInput"; | |||
|
|
|||
| export const OtpInput = forwardRef<OtpInputRef, OtpInputProps>((props, ref) => { | |||
| export const OtpInput = forwardRef<OtpInputRef, OtpInputProps>((props: OtpInputProps, ref) => { | |||
There was a problem hiding this comment.
No need for this change; props types getting populated from forwardRef<> generics
anday013
reviewed
Sep 15, 2024
| @@ -15,7 +15,8 @@ | |||
| "test:coverage": "jest --collectCoverage --coverageDirectory=\"./coverage\"", | |||
| "build:dev": "tsc", | |||
| "build:prod": "tsc -p tsconfig.prod.json", | |||
| "prepublishOnly": "npm install && npm run build:prod" | |||
| "prepublishOnly": "npm install && npm run build:prod", | |||
| "prepare": "npm run build:prod" | |||
There was a problem hiding this comment.
Without prepare script I was not able to get dist folder while installing my fork as:
npm install git@github.com:BogdanGorelkin/react-native-otp-entry.git
|
I tested, works fine, thank you. Just update the snapshot and address my comments, then we'll be good to go :) |
|
@BogdanGorelkin hey, any updates here? |
Hi, @anday013 , sure, check the answers above to your comments. |
|
can we merge this? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When prop type was set to 'alphanumeric' the keyboard remains numeric.
Please approve it, because now it works perfectly for both types.