[FEATURE] Allow storage configuration override in config/system/addit… #145
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chivy-we
reviewed
Jun 28, 2024
| @@ -218,7 +218,8 @@ public function processConfiguration() | |||
| */ | |||
| public function initialize() | |||
| { | |||
| $this->initializeBaseUrl() | |||
| $this->loadSettings() | |||
There was a problem hiding this comment.
What do you think if we don't create new "loadSettings" function? We just apply code the inside the "initializeSettings", move "initializeSettings()" to the top of "initializeBaseUrl()".
$this->initializeSettings()
->initializeBaseUrl()
->initializeClient();
…ional.php
Record-based storage configuration can be overridden by defining
$GLOBALS['TYPO3_CONF_VARS']['EXTENSIONS']['aus_driver_amazon_s3']['storage']
or
$GLOBALS['TYPO3_CONF_VARS']['EXTENSIONS']['aus_driver_amazon_s3']['storage_X']
(where X is the UID of the storage record)
in config/system/additional.php.
This makes it possible to use environment variable based storage configuration,
and no secret keys need to be stored in the database anymore.
Storage configuration in the database record is merged with the generic
'storage' configuration, which then with the uid-specific storage config.
Example for defining the credentials in config/system/additional.php:
$GLOBALS['TYPO3_CONF_VARS']['EXTENSIONS']['aus_driver_amazon_s3']['storage_23'] = [
'key' => $_ENV['S3_KEY'],
'secretKey' => $_ENV['S3_SECRET'],
];
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ional.php
Record-based storage configuration can be overridden by defining
$GLOBALS['TYPO3_CONF_VARS']['EXTENSIONS']['aus_driver_amazon_s3']['storage']or
$GLOBALS['TYPO3_CONF_VARS']['EXTENSIONS']['aus_driver_amazon_s3']['storage_X'](where X is the UID of the storage record)
in config/system/additional.php.
This makes it possible to use environment variable based storage configuration, and no secret keys need to be stored in the database anymore.
Storage configuration in the database record is merged with the generic 'storage' configuration, which then with the uid-specific storage config.
Example for defining the credentials in config/system/additional.php: