Add first functional tests #153
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The XDEBUG variables defined in the docker-compose.yml file command blocks were not used under docker 20.10.24+dfsg1 with docker compose version v2.29.2. This led to the problem that Bootstrap::init took 37 seconds, wasting developer time. By switching to "export" calls, the variables get set properly and php/xdebug runs fast. A single functional test run is 3 seconds now.
based on the files in Tests/Functional/Bucketfiles/
Created with the Build/testing-docker/prepare-minio-data.sh Committed here so that "mc" (minio client) is not needed to run the tests.
./Build/Scripts/runTests.sh -p 8.2 -d sqlite -s functional -e "--display-warnings --display-notices --display-errors"
We use a local minio instance to run the tests against. Run them with ./Build/Scripts/runTests.sh -p 8.2 -d sqlite -s functional -e "--display-warnings --display-notices --display-errors"
|
I've added the functional tests to the github actions file, but they do not run automatically:
|
- amend commit to trigger build
cweiske
force-pushed
the
functional-tests
branch
from
f0da656
to
d9fa566
Compare
ubuntu-20.04 brings an error: > Run Build/Scripts/runTests.sh -p 8.0 -s composerInstall > Build/Scripts/runTests.sh: line 107: type: docker-compose: not found > This script relies on docker and docker-compose. Please install
.. typo3/testing-framework 8 needs a higher version
|
The tests run! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds the first functional tests for
aus_driver_amazon_s3.The tests are run against a local MinIO instance that is started with the container that the tests are run in.
A prepared
test-bucketis provided that MinIO can use without initial setup, which keeps test setup time low and keeps dependencies at minimum.Some of the tests are marked skipped because they exhibit bugs that get fixed with #147.
The functional tests do not yet get automatically run on github actions since I don't know how to do that properly.
I run the tests locally with
and they complete in 3 seconds.