-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BUGFIX] Correctly set MIME type of .js and .css files #86
base: master
Are you sure you want to change the base?
Conversation
I'm not sure if we should fix this mime type issue here in this driver. Do you know the real source of this issue? Can we solve it in a more generic way (eg. for all mime types)? |
The TYPO3 core also has a similar problem and introduced the MimeTypeDetector: There is a manual list of mappings, too, that is used by FileInfo:
I don't know what the right solution is. |
1ff78b7
to
23f1f39
Compare
0a8f582
to
aa5032b
Compare
I've rebased against current master and fixed the code complexity by moving the code into a new method. @Lagerregal: Shall I rewrite it to use the TYPO3 core mime type detector, or is the current list of css+js sufficient? (Also, this only works for files that are not empty because the normal s3client uploader is used for empty files since #69, and I do not know how to pass the MIME type to that. |
As long as the issue gets finally solved I'm fine with that :) |
Resolves: #85