Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUGFIX] Correctly set MIME type of .js and .css files #86

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

cweiske
Copy link
Contributor

@cweiske cweiske commented Jul 22, 2021

Resolves: #85

@Lagerregal
Copy link
Collaborator

I'm not sure if we should fix this mime type issue here in this driver. Do you know the real source of this issue? Can we solve it in a more generic way (eg. for all mime types)?

@cweiske
Copy link
Contributor Author

cweiske commented Apr 3, 2022

@cweiske cweiske force-pushed the js-mimetype branch 2 times, most recently from 1ff78b7 to 23f1f39 Compare October 13, 2022 11:42
@cweiske cweiske force-pushed the js-mimetype branch 3 times, most recently from 0a8f582 to aa5032b Compare November 17, 2022 17:27
@cweiske
Copy link
Contributor Author

cweiske commented Nov 17, 2022

I've rebased against current master and fixed the code complexity by moving the code into a new method.

@Lagerregal: Shall I rewrite it to use the TYPO3 core mime type detector, or is the current list of css+js sufficient?

(Also, this only works for files that are not empty because the normal s3client uploader is used for empty files since #69, and I do not know how to pass the MIME type to that.

@weakbit
Copy link
Contributor

weakbit commented Jan 4, 2024

@cweiske
thanks again for your contribution.
I created another PR for that: #141 as i decided to use the TYPO3 mime-detector mappings for that issue.

@cweiske
Copy link
Contributor Author

cweiske commented Jan 4, 2024

As long as the issue gets finally solved I'm fine with that :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

MIME type of .js file: text/plain
3 participants