Skip to content
This repository has been archived by the owner on Nov 28, 2023. It is now read-only.

Fix --pretty option to make it independent of Netlify #224

Closed
andi1984 opened this issue Dec 2, 2020 · 0 comments · Fixed by #226
Closed

Fix --pretty option to make it independent of Netlify #224

andi1984 opened this issue Dec 2, 2020 · 0 comments · Fixed by #226
Labels
bug Something isn't working

Comments

@andi1984
Copy link
Owner

andi1984 commented Dec 2, 2020 •
edited
Loading

Right now the --pretty option is working only with Netlify because of the case that the html file is NOT called index.html.

So the logic should be:

foo/index.md --> always example.com/foo

foo/bar.md --> example.com/foo/bar.html if pretty is false and example.com/foo/bar if it is true

Furthermore move pretty to env var instead of being solely a CLI param.
@andi1984 andi1984 added the bug Something isn't working label Dec 2, 2020
andi1984 added a commit that referenced this issue Dec 7, 2020
@andi1984
fix(pretty-urls): Limiting pretty URLs for trailing index URL segment
710b430 
For the sake of more wide deployment support, we limit/restrict the
pretty URL support for trailing "index" URL segments only.

Before it was not restricted to this, means: "foo.com/mypage.html" was
transformed "foo.com/mypage". This case is taken out now and will stay
like "foo.com/mypage.html".

Fixes #224
@andi1984 andi1984 mentioned this issue Dec 7, 2020
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(pretty-urls): Limiting pretty URLs for trailing index URL segment andi1984/back2roots
1 participant
@andi1984