Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Version of RE2 being wrapped? #34

Open
adamhamlin opened this issue Nov 7, 2021 · 4 comments
Open

Version of RE2 being wrapped? #34

adamhamlin opened this issue Nov 7, 2021 · 4 comments

Comments

@adamhamlin
Copy link

This is not a proper issue, just a question about which version of re2 is being wrapped.

Based on some log statements that appeared, my guess is that the re2 version is 2016-XX-XX or older, but I'm not positive. Where in the code is that specified or computed?

Thanks

@andreasvc
Copy link
Owner

If you compile from source, it uses the version you have installed. If you use e.g. the Linux wheel, it has been compiled against the libre2-dev version on Ubuntu 20.04.

Why do you ask?

@adamhamlin
Copy link
Author

I am trying to use the latest pypi package (version 0.3.6), but noticed some different behavior when using it on macos vs linux on docker. Specifically, seeing this INFO log but only on docker: https://github.com/google/re2/blob/78dd4fa1f86bafbf5a5eb006778d9e6e27297af6/re2/dfa.cc#L472

That's re2 version 2016-09-01, but that log message changes/moves on later versions, so mine must be using 2016-09-01 or earlier.

Am I missing something? Or Is there no packaged version that's using a more recent re2 build?

@sarnold
Copy link

sarnold commented Dec 16, 2022

You are right that the current manylinux wheels are built with a (now)deprecated version, including a really old version of the google-y library. Among other updates, we'll be updating the platform wheel builds along the way. Thanks for the report!

@sarnold
Copy link

sarnold commented Sep 8, 2024

There is now an open PR #47 that has the latest cibuildwheel that includes the latest quay.io docker image with a newer CentOS and re2. After this gets addressed and I have my next "free" time I can look at vendoring the google-y source bits for the platform wheels. In the mean time you can use a tox env to use native build BUT you would need to install the build deps (mainly re2 and pybind11) before building with tox. @adamhamlin also feel free to try the platform wheel artifacts in the PR checks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants