CI, python, and cmake cleanup #47
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* update pybind11 usage and set cmake python vars to Title_CASE * refactor cmake extension build to use pybind11 module bits * move emptygroups test from "differences" Signed-off-by: Steve Arnold <sarnold@vctlabs.com>
* cleanup asserts and add groups() test Signed-off-by: Steve Arnold <sarnold@vctlabs.com>
* refactor setup.py after pybind11 upstream changes Signed-off-by: Steve Arnold <sarnold@vctlabs.com>
Signed-off-by: Steve Arnold <sarnold@vctlabs.com>
Signed-off-by: Steve Arnold <sarnold@vctlabs.com>
* cleanup ci workflow, remove crufty makefile with deprecated setup.py commands * remove the package_dir bit from setup.py Signed-off-by: Steve Arnold <sarnold@vctlabs.com>
* check if find_package py3 works across all CI runners Signed-off-by: Steve Arnold <sarnold@vctlabs.com>
* no epel pkgs for linux aarch64, enable PYBIND11_FINDPYTHON * set macos deployment target to 10.9 Signed-off-by: Steve Arnold <sarnold@vctlabs.com>
Signed-off-by: Steve Arnold <sarnold@vctlabs.com>
…2024.07.02 Signed-off-by: Stephen L Arnold <nerdboy@gentoo.org>
* revert to macos-13 with the same version as target * In Theory this should get us full c++17 Signed-off-by: Stephen Arnold <nerdboy@gentoo.org>
… cfg Signed-off-by: Stephen Arnold <nerdboy@gentoo.org>
sarnold
force-pushed
the
py-cleanup
branch
5 times, most recently
from
771cf2c
to
5696f8a
Compare
* split all runners into separate arch via matrix * macos does need macos-14 to get a proper arm64 build Signed-off-by: Stephen Arnold <nerdboy@gentoo.org>
sarnold
force-pushed
the
py-cleanup
branch
4 times, most recently
from
567729c
to
e69afb2
Compare
Signed-off-by: Stephen Arnold <nerdboy@gentoo.org>
|
So this is telling us there is still some Py2 cruft somewhere, possibly just a n import, or else it would not be looking for 'six'. |
* this is essentially a workaround for non-pypi pkg cruft Signed-off-by: Stephen Arnold <nerdboy@gentoo.org>
Signed-off-by: Stephen Arnold <nerdboy@gentoo.org>
sarnold
force-pushed
the
py-cleanup
branch
2 times, most recently
from
6ab899d
to
59d742f
Compare
* also cleanup the wheel artifact check, download to artifacts/ Signed-off-by: Stephen Arnold <nerdboy@gentoo.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I started this earlier in the year but then I got busy and had to add more fixes on top of fixes, but it's clean again. So
This does address C++ std warnings in issue #46 as well as #48, #44, #43, and stale/other version issues. You should probably validate the fix for #48 just to make sure