Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename smurf named methods #942

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

dturner
Copy link
Collaborator

@dturner dturner commented Apr 17, 2023

Here's what I've done and why:

  • Removed Task from TaskRepository methods to avoid smurf naming e.g createTask becomes just create.
  • Changed get to observe for methods which return a Flow. This is less verbose and more accurate than getTaskStream.
  • Methods which return a List<Task> have All after the verb e.g. observeAll and `clearAllCompleted.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant