Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add RTSP VP8 Reader test #101

Closed
wants to merge 2 commits into from

Conversation

basantwanishraddha
Copy link
Contributor

No description provided.

Initialise fragmentedSampleSizeBytes with 0, instead
of UNSET since we directly add sample size to it.

Change-Id: I9d5735422a4a0eeb2967af93809b879b434e3c57
Update VP8 Reader to handle missing frames/fragments.

Change-Id: I9eede8f1e3a20fb0ff2e7add0dfc60f0780ec769
@claincly
Copy link
Contributor

claincly commented Jul 1, 2022

A general question before start reviewing: why there are changes to the VP8 reader? Is it adding new feature, or is it a bug fix?

@basantwanishraddha
Copy link
Contributor Author

Fix VP8 Reader commit is a bug fix. And we have added the test as a separate commit.

@claincly
Copy link
Contributor

claincly commented Jul 1, 2022 via email

@basantwanishraddha
Copy link
Contributor Author

Created a new PR, abandoning this PR.
I have updated the Fix VP8 Reader commit with relevant bug id and description.

@androidx androidx locked and limited conversation to collaborators Mar 3, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants