-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add sorbet #13
Open
andyw8
wants to merge
21
commits into
master
Choose a base branch
from
add-sorbet
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Add sorbet #13
Changes from 19 commits
Commits
Show all changes
21 commits
Select commit
Hold shift + click to select a range
89f2d7e
Remove Virtus
andyw8 0549d24
Add sorbet
andyw8 af74a3a
Sorbet init
andyw8 e206729
Disable type checks for spec files
andyw8 0b7448c
Enable sorbet-runtime
andyw8 7491725
Enable strict checking for Position
andyw8 d9b6bfe
Enable strict checking for LineRange
andyw8 7552a17
Avoid unnecessary double
andyw8 d17a1cf
Enable strict type checking for Issue
andyw8 597c82b
Avoid bare mocks for Sorbet compatibilty
andyw8 01e715d
Enable strict type checking for Category
andyw8 6a17827
Enable strict typing
andyw8 e6a860b
Enable Strict type checking for Grid
andyw8 83c3ce4
Enable strict type checking for Offset
andyw8 97075b7
Enable strict type checking for Config
andyw8 c8cc5fe
Use sorbet 0.5
andyw8 fb68923
Make use of Sorbet 0.5 to simplify
andyw8 f5bdc2d
Regenerate RBI files
andyw8 b231742
Mark sorbet/ to hide in GitHub PR view
andyw8 d1fd72e
Try using T::Struct (failing)
andyw8 464b610
Add explicit dependency
andyw8 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1 @@ | ||
sorbet/* linguist-generated=true |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,2 +1,3 @@ | ||
# typed: strict | ||
require "cc_engine/location/line_range" | ||
require "cc_engine/location/position" |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,19 +1,28 @@ | ||
require "virtus" | ||
|
||
# typed: strict | ||
module CCEngine | ||
module Position | ||
class Grid | ||
include Virtus.model(strict: true) | ||
extend T::Sig | ||
|
||
attribute :line, Integer | ||
attribute :column, Integer | ||
sig {params(line: Integer, column: Integer).void} | ||
def initialize(line:, column:) | ||
@line = line | ||
@column = column | ||
end | ||
|
||
sig {returns(T::Hash[Symbol, T.untyped])} | ||
def to_hash | ||
{ | ||
line: line, | ||
column: column | ||
} | ||
end | ||
|
||
sig {returns(Integer)} | ||
attr_reader :line | ||
|
||
sig {returns(Integer)} | ||
attr_reader :column | ||
end | ||
end | ||
end |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,17 +1,25 @@ | ||
require "virtus" | ||
# typed: strict | ||
|
||
module CCEngine | ||
module Position | ||
class Offset | ||
include Virtus.model(strict: true) | ||
|
||
attribute :offset, Integer | ||
extend T::Sig | ||
sig {params(offset: Integer).void} | ||
def initialize(offset:) | ||
@offset = offset | ||
end | ||
|
||
sig {returns(T::Hash[Symbol, T.untyped])} | ||
def to_hash | ||
{ | ||
offset: offset | ||
} | ||
end | ||
|
||
private | ||
|
||
sig { returns(Integer) } | ||
attr_reader :offset | ||
end | ||
end | ||
end |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,3 +1,4 @@ | ||
# typed: strict | ||
module CCEngine | ||
VERSION = "0.4.1" | ||
end |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No idea what Virtus is doing, but this looks really similar to what
T::Struct
does. You might want to take a look and see if it fits your needs if you haven't already.