Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SIANXKE-346: Allow up-check to distinguish between errors and warnings #12

Merged
merged 1 commit into from
Jun 12, 2024

Conversation

beachmachine
Copy link
Contributor

@beachmachine beachmachine commented Oct 20, 2023

Changed

  • Distinguish between errors and warnings on up-check
  • Register built-in up-checks via the monitor_up_check signal

@codecov-commenter
Copy link

codecov-commenter commented Oct 20, 2023

Codecov Report

Attention: 4 lines in your changes are missing coverage. Please review.

Comparison is base (a120ffc) 94.52% compared to head (a652ec6) 91.20%.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master      #12      +/-   ##
==========================================
- Coverage   94.52%   91.20%   -3.32%     
==========================================
  Files           4        4              
  Lines          73       91      +18     
==========================================
+ Hits           69       83      +14     
- Misses          4        8       +4     
Files Coverage Δ
anexia_monitoring/decorators.py 93.75% <ø> (ø)
anexia_monitoring/events.py 100.00% <ø> (ø)
anexia_monitoring/urls.py 100.00% <ø> (ø)
anexia_monitoring/views.py 90.00% <85.71%> (-4.24%) ⬇️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

run: |
python -m pip install --upgrade pip
pip install flake8 codecov
pip install -r requirements.txt
pip install django~=${{ matrix.django-version }}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nezhar nezhar merged commit a652ec6 into master Jun 12, 2024
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants