-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support npm CLI 3.x #35
base: master
Are you sure you want to change the base?
Conversation
@cpetrov I'm sorry, but I don't understand very well your PR? It seems that yoru PR contains too changes of PR #33 and why have you changed the path of acorn inside HTML page demo? Before acorn was declared in the package.json. Now it is not declared because it must be the same acorn version than tern. I suggets you that you remove your node_modules and do npm install. |
Done to support npm 3.x CLI.
With npm version 3.x ( |
Ok I understand, but I think we should provide simple demo: user does just npm install (without some option) and it works directly. Are you agree with me? |
Bundling required dependencies with a tool like Browserify may be an option? |
As I said you, I woud like to have a simple thing. Just do "npm install". Demo is just to play with them, that's all. |
Users would still have to Before this PR doing This change would however break dependency structure for users with older npm versions (<3.x). That's why I thought dependencies could be alternatively bundled to make the demo easier to consume without relying on a specific version of the globally installed npm. Do you have any other ideas? I hope I understood you right :) |
@cpetrov I have installed last version of node.js https://nodejs.org/en/download/ which is v4.2.1 and which provides npm 2.14.7. I don't know how to install npm 3.x. Is it an official version? |
After finish this PR, can I create a release? |
@angelozerr Sure! LTS includes 2.14.7, Stable (https://github.com/nodejs/node/blob/v5.0.0/CHANGELOG.md) includes 3.3.6. LTS is the default option when downloading Node.js though. Should we wait until npm is also updated for LTS? |
Yes I prefer waiting. Do you know if there is an option with npm < 3.x which does the same thing than npm 3.x?
Release 0.4.0 was done. |
Package dependencies are now installed in the root "node_modules" directory when possible.