Marker position does not update when edited #946
Comments
|
Confirmed. I need to revisit this code in my PR as well. #948 |
|
Found the issue so when it gets to looking for updates it compares model to ChildModel.model, well they are somehow pointing to the same reference (not sure how they were not before). Anyway one ChildModel creation passing in a clone of model alleviates the problem. As an alternative the model comparison could compare the model to a gObject. However this would require more code changes that are desired right now. |
Cloning Model to make sure there is an oldModel and newModel to compare to .
|
Confirmed that this happens as of 2.0.2. From that version on doRebuildAll needs to be set for the markers to move. Just did a bunch of manual testing to verify. |
specs to verify delayed updates - reference update - direct model changes (within the models array) MockMarker fixes to make setOptions mutable with position
|
@grahamj yes it is confirmed with a PR fix |
|
Along with specs to check it for now on. |
|
Great thx! |
|
This is going to take a little extra work if you want it fixed on the 2.0.X branch. The work i did that resolves this issue has been considered 2.1.X . So I need to backtrace some fixes to 2.0.X . But this will be one of the last commit sets for 2.0.X. |
- This is ripe for a ChildBase Class This makes angular-ui#946 and angular-ui#772 compatible
When altering a markers location, the change is not reflected in the map. It seems as though the markers location is not watched.
See this example. Clicking the "Move a Marker" button should move the marker to a new random location.
The hack we've had to use to get this working is to use the
doRebuildAllattribute to force the map to update. You can see this works by addingdoRebuildAll="true"to the to the marker cluster element in the above Plunkr, but this solution is horrible...Is this a bug in the clusterer?
The text was updated successfully, but these errors were encountered: