refactor(rating): moving default class names back to template

angular-ui · Aug 27, 2013 · 87b4aa7 · 87b4aa7
1 parent ff9d969
commit 87b4aa7
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 7 deletions.
diff --git a/src/rating/docs/readme.md b/src/rating/docs/readme.md
@@ -25,12 +25,12 @@ Rating directive that will take care of visualising a star rating bar.
  	An optional expression called when user's mouse leaves the control altogether.
 
  * `state-on`
- 	_(Defaults: 'icon-star')_ :
- 	A variable used in default template to specify the class for selected icons.
+ 	_(Defaults: null)_ :
+ 	A variable used in template to specify the state (class, src, etc) for selected icons.
 
  * `state-off`
- 	_(Defaults: 'icon-star-empty')_ :
- 	A variable used in default template to specify the class for unselected icons.
+ 	_(Defaults: null)_ :
+ 	A variable used in template to specify the state for unselected icons.
 
  * `rating-states`
  	_(Defaults: null)_ :

diff --git a/src/rating/rating.js b/src/rating/rating.js
@@ -2,8 +2,8 @@ angular.module('ui.bootstrap.rating', [])
 
 .constant('ratingConfig', {
   max: 5,
-  stateOn: 'icon-star',
-  stateOff: 'icon-star-empty'
+  stateOn: null,
+  stateOff: null
 })
 
 .controller('RatingController', ['$scope', '$attrs', '$parse', 'ratingConfig', function($scope, $attrs, $parse, ratingConfig) {

diff --git a/template/rating/rating.html b/template/rating/rating.html
@@ -1,3 +1,3 @@
 <span ng-mouseleave="reset()">
-	<i ng-repeat="r in range" ng-mouseenter="enter($index + 1)" ng-click="rate($index + 1)" ng-class="$index < val && r.stateOn || r.stateOff"></i>
+	<i ng-repeat="r in range" ng-mouseenter="enter($index + 1)" ng-click="rate($index + 1)" ng-class="$index < val && (r.stateOn || 'icon-star') || (r.stateOff || 'icon-star-empty')"></i>
 </span>