Skip to content
This repository has been archived by the owner on May 29, 2019. It is now read-only.

feat(modal): Support custom window html #2056

Closed
wants to merge 1 commit into from

Conversation

nl5887
Copy link

@nl5887 nl5887 commented Apr 13, 2014

the window attribute allows to use separate custom windows per modal
instance

the window attribute allows to use separate custom windows per modal
instance
@bekos
Copy link
Contributor

bekos commented Apr 13, 2014

@nl5887 Thx for the PR, but creating another directive just to override the template is not the best solution, as this is going to be hard to maintain, ie keeping in sync your custom directive with the official one. Please check #2057 if this is what you are after.

@nl5887
Copy link
Author

nl5887 commented Apr 15, 2014

Hmm, reason I've implemented it this way is to have the possibility (full control) to have an own controller, eg overwriting or customizing behaviour like the close.

@bekos
Copy link
Contributor

bekos commented Apr 15, 2014

I see, but the way to go, is to override/communicate with what modal decides to expose, and not trying to replace the whole thing. If this is what you want, you can create your own directive anyway, without depending on $modal's behaviour.

@pkozlowski-opensource
Copy link
Member

@nl5887 thnx a bunch for this pull request, but finally I've decided to merge #2057 instead. Hope to see other contributions from you, though!

@nl5887
Copy link
Author

nl5887 commented Apr 19, 2014

Ok, thnx.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants