-
Notifications
You must be signed in to change notification settings - Fork 659
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
1 simple test for calculator service #3
Open
sspinit88
wants to merge
10
commits into
angular-university:master
Choose a base branch
from
sspinit88:1-simple-test-for-CalculatorService
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
1 simple test for calculator service #3
sspinit88
wants to merge
10
commits into
angular-university:master
from
sspinit88:1-simple-test-for-CalculatorService
Commits on Apr 4, 2019
-
Your Name committed
Apr 4, 2019 Configuration menu - View commit details
-
Copy full SHA for 2e51b4c - Browse repository at this point
Copy the full SHA 2e51b4cView commit details
Commits on May 2, 2019
-
Your Name committed
May 2, 2019 Configuration menu - View commit details
-
Copy full SHA for ee05f8e - Browse repository at this point
Copy the full SHA ee05f8eView commit details
Commits on May 17, 2019
-
Configuration menu - View commit details
-
Copy full SHA for 0bb2901 - Browse repository at this point
Copy the full SHA 0bb2901View commit details
Commits on Jun 3, 2019
-
Configuration menu - View commit details
-
Copy full SHA for 8b0bcdd - Browse repository at this point
Copy the full SHA 8b0bcddView commit details
Commits on Jun 7, 2019
-
upgrade to Angular 8 and Node 12
Your Name committedJun 7, 2019 Configuration menu - View commit details
-
Copy full SHA for 9a2c947 - Browse repository at this point
Copy the full SHA 9a2c947View commit details
Commits on Jun 22, 2019
-
Adds appropriate types to
courses.service.ts
The course is missing the correct types for the `saveCourse` method so that tests were unable to run properly. Looks like this is fixed on the master branch but is not implemented in the 1-start branch. Changes: - Adds correct type information to saveCourse method in `course.service.ts`
Configuration menu - View commit details
-
Copy full SHA for 0c27922 - Browse repository at this point
Copy the full SHA 0c27922View commit details
Commits on Jun 25, 2019
-
Merge pull request angular-university#2 from duncannevin/patch-1
Adds appropriate types to `courses.service.ts`
Configuration menu - View commit details
-
Copy full SHA for 66458db - Browse repository at this point
Copy the full SHA 66458dbView commit details
Commits on Dec 1, 2019
-
Configuration menu - View commit details
-
Copy full SHA for eabb0c4 - Browse repository at this point
Copy the full SHA eabb0c4View commit details -
Configuration menu - View commit details
-
Copy full SHA for b544cc6 - Browse repository at this point
Copy the full SHA b544cc6View commit details -
Configuration menu - View commit details
-
Copy full SHA for 91b493f - Browse repository at this point
Copy the full SHA 91b493fView commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.