Github security warning for hoek

[StephenFluin]

Bug Report or Feature Request (mark with an x)

- [X] bug report -> please search issues before submitting

Versions

Angular CLI: 6.1.1
Node: 10.7.0
OS: linux x64
Angular: 6.1.0
... animations, common, compiler, compiler-cli, core, forms
... http, language-service, platform-browser
... platform-browser-dynamic, router

Package Version

@angular-devkit/architect 0.6.8
@angular-devkit/build-angular 0.6.8
@angular-devkit/build-optimizer 0.6.8
@angular-devkit/core 0.6.8
@angular-devkit/schematics 0.7.1
@angular/cdk 6.4.1
@angular/cli 6.1.1
@angular/material 6.4.1
@ngtools/webpack 6.0.8
@schematics/angular 0.7.1
@schematics/update 0.7.1
rxjs 6.2.2
typescript 2.7.2
webpack 4.8.3

Repro steps

• ng new my-app
• push my-app to github

You can use yarn why to see why we have hoek

• yarn why hoek

=> Found "hoek@2.16.3"
info Reasons this module exists
   - "@angular-devkit#build-angular#node-sass#node-gyp#request#hawk" depends on it

The log given by the failure

This links to: https://nvd.nist.gov/vuln/detail/CVE-2018-3728

Desired functionality

Remove or bump dependency on node-sass to remove dependency on reported vulnerability in hoek.

[clydin]

To fully rectify the issue for all users, this PR (nodejs/node-gyp#1471) is required for node-gyp followed by a release and version bump in node-sass and finally a version bump on the CLIs end.

[alexeagle]

@clydin how about we fix this by moving to the new canonical sass compiler which is npmjs.com/sass

[clydin]

Sounds good. Would we need to target 7.0 due to the potential for behavior differences? This PR for the webpack loader would also be blocking (webpack-contrib/sass-loader#573) unless we wanted to make our own.

[kmturley]

This seems to fix it:
npm install hoek@4.2.1

[angular-automatic-lock-bot]

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

_{This action has been performed automatically by a bot.}